Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore deprecation warnings from pkg_resources #1930

Merged

Conversation

matrss
Copy link
Collaborator

@matrss matrss commented Aug 24, 2023

Purpose of PR?:

Ignore deprecation warnings for namespace packages that are not conformant with PEP420, e.g. due to using pkg_resources.declare_namespace. Related to #1919, I think we should keep that issue open until this is actually fixed in our dependencies and we can remove the warning filters again, though.

Does this PR introduce a breaking change?

No

If the changes in this PR are manually verified, list down the scenarios covered::

pytest, checking that the deprecation warnings do not show up.

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@matrss matrss added this to the 9.0.0 milestone Aug 24, 2023
@matrss matrss added the tests label Aug 24, 2023
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@ReimarBauer ReimarBauer merged commit 8840071 into Open-MSS:develop Aug 24, 2023
4 checks passed
@matrss matrss deleted the ignore-namespace-deprecation-warnings branch February 16, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants